feat: add go module redirect for k8s-operator #380
Conversation
Signed-off-by: Dan Molik <[email protected]>
|
@dmolik So it looks like you don't actually need any of the rest of the template and this page wouldn't really be visited by humans? If so, I think a more elegant way of doing this would be to create a standalone go-forwarding template that doesn't rely on the existing templates but has the two meta tags you need for Golang. As-is would work but we're trying to gently optimize for a nice quick build process - this conditional would be evaluated on every page of the website - we can handle it today but too many of these tech debt over time. |
|
@dmolik I just added #394 - after that is merged you can avoid the complexity in this PR. In [extra]
custom_meta = """
<meta name="go-import" content="valkey.io/valkey-operator git https://github.com/valkey-io/valkey-operator">
<meta name="go-source" content="valkey.io/valkey-operator https://github.com/valkey-io/valkey-operator https://github.com/valkey-io/valkey-operator/tree/main{/dir} https://github.com/valkey-io/valkey-operator/blob/main{/dir}/{file}#L{line}">
"""You don't need to change: |
### Description In #380, @dmolik was trying to add a custom meta tags for the go package manager. His solution was limited and specific to to the specific situation with the go package manager but custom tags in the header are not an uncommon ask, so I wanted a generalizable solution. This PR adds the ability for add tags directly to any page in the meta block. ### Issues Resolved n/a ### Check List - [x] Commits are signed per the DCO using `--signoff` By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License. Signed-off-by: Kyle J. Davis <[email protected]>
2 participants
Description
the Golang import path for the new valkey-operator is valkey.io/valkey-operator this patch wires up a redirect to use the patch but also keep the code within GitHub.
Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.